Refactor events and create new Mixin-Class for events #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Falke-Design
commented
Apr 11, 2021
There was a problem hiding this comment.
One Mixin for all. Only one event exists centerplaced -> same payload for edit and draw. Events that have undefined arguments, need to be explained why.
Description for event.
Add source from where event is fired
Add a arguement custom Payload and merge it with the current one
|
TODO: Add new Events f.ex. Rotation - merge first all other PRs |
codeofsumit
approved these changes
May 11, 2021
…into refactor_events # Conflicts: # src/js/Edit/L.PM.Edit.Marker.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After refactoring 90 direct calls minified to 36 on
_fireEvent.Now we can be sure, that every event pass the same arguments.